feat: keystore decoding #703
Open
+127
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
gomesalexandre
commented
Jan 3, 2025
|
|
||
| const { kdfparams } = keystore.crypto; | ||
|
|
||
| // Derive key using PBKDF2 similar to SwapKit's `pbkdf2Async` call |
There was a problem hiding this comment.
gomesalexandre
commented
Jan 3, 2025
| // Derive key using PBKDF2 similar to SwapKit's `pbkdf2Async` call | ||
| const passwordKey = await ( | ||
| await crypto | ||
| ).subtle.importKey("raw", encoder.encode(password), "PBKDF2", false, ["deriveBits"]); |
There was a problem hiding this comment.
gomesalexandre
commented
Jan 3, 2025
Comment on lines
+183
to
+188
| async loadFromKeystore(stringifiedKeystore: string, password: string) { | ||
| const keystore = JSON.parse(stringifiedKeystore); | ||
| const mnemonic = await decryptFromKeystore(keystore, password); | ||
| this.set("#mnemonic", mnemonic); | ||
| return this; | ||
| } |
There was a problem hiding this comment.
Looks unused, but actually adds loadsFromKeystore to Vault class for clients' consumption e.g:
https://github.com/shapeshift/web/pull/8442/files#diff-cb441bd026f8d983d9243fba41e8f70444867e130f150f1b25a22de360dd0008R51
gomesalexandre
commented
Jan 3, 2025
There was a problem hiding this comment.
Placeholder comment - as usual, don't forget to bump hdwallet versions with lerna before merging me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds Keystore decoding support, following Swapkit's (https://github.com/thorswap/SwapKit/blob/349a9212d8357cc35a8bab771728bbc8d6900ebc/packages/wallets/keystore/src/helpers.ts) logic.
Note, logic has been redeclared here, as SwapKit build is all sorts of broken re: transitive dependencies and I couldn't get it to work after way too many tries.
Issue
Testing
Screenshots